Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_tv_run_inversion broken in parallel #106

Open
dngoldberg opened this issue Sep 8, 2022 · 1 comment
Open

test_tv_run_inversion broken in parallel #106

dngoldberg opened this issue Sep 8, 2022 · 1 comment
Assignees

Comments

@dngoldberg
Copy link
Collaborator

The test_tv_run_inversion test throws a runtime error when run with MPI (n>1):

def test_tv_run_inversion(persistent_temp_model, monkeypatch):

Note that an assertion error is thrown but NOT the one tested by pytest, but rather a line 259 of solver.py.

The toml has both alpha and beta active, and a dual inversion is run; the solver object therefore expects a tuple of parameter functions. im not sure the best way to handle it. One way would be to modify the toml (at runtime or by changing the file) and set beta_active to False. But then the inversion would not be a dual one, and the gradient of beta would not be tested. i think alpha is the more important to test due to the grounding line though.

The same likely applies to test_tv_run_forward but i have not tested it.

@dngoldberg dngoldberg assigned dngoldberg and bearecinos and unassigned dngoldberg Sep 8, 2022
@bearecinos
Copy link
Collaborator

bearecinos commented Sep 8, 2022

Weird I see what you mean I'll have a look at this after I finish sending oggm runs ... maybe these tests will benefit from a independent toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants