Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete commented and deprecated code, unused variables and libraries #31

Open
bearecinos opened this issue Dec 16, 2021 · 5 comments
Open
Assignees
Labels
deprecated needs further examination but can be deleted

Comments

@bearecinos
Copy link
Collaborator

There lots of unused code or deprecated code that needs to be deleted and/or examined.
Examples where to start:

  • Tons of unsolved references in model.py functions from specific libraries are never called at the beginning of the file, see here a few examples:

  • 1, 2, 3

  • functions in model.py that are never used: init_vel_obs_old

  • Unused and commented code in solver.py some examples: 1, 2, def_thickadv_eq(self) and more in same function

Tons of unused / commented code in solver.py/inversion!:

  • these type of code for example if we don't deleted at least should become an option, as it looks like is a different method?
@bearecinos bearecinos self-assigned this Dec 16, 2021
@bearecinos bearecinos added the deprecated needs further examination but can be deleted label Dec 16, 2021
@bearecinos
Copy link
Collaborator Author

bearecinos commented Feb 15, 2022

@jrmaddison looking around in the code I encounter this commented part about TV. and makes me wonder that probably we need to uncomment this if we run the taylor verification. I haven't notice this before...
https://github.com/bearecinos/fenics_ice/blob/main/fenics_ice/solver.py#L783-L790

@jrmaddison
Copy link
Collaborator

The unit tests perform their own verification, so the commented out code could be removed or restored, depending on whether it's useful to always run a Taylor test ahead of an inversion.

@bearecinos
Copy link
Collaborator Author

bearecinos commented Mar 16, 2022

@jrmaddison , @dngoldberg
Do we need these scripts:

but the first two could be deleted right? or move to a sandbox

@dngoldberg
Copy link
Collaborator

@bearecinos last one is used in tests. 2nd should be moved to sandbox if you can do so easily. looks like process_eigendec plots eigenvalues and saves eigenvectors to a file for visualisation. i believe we are now using other code that does this -- right?? can you check to be sure it is not used by any of the ismip example cases?

@bearecinos
Copy link
Collaborator Author

will check! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated needs further examination but can be deleted
Projects
None yet
Development

No branches or pull requests

3 participants