Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question the need for H_np and U_np #60

Open
dngoldberg opened this issue Feb 26, 2022 · 1 comment
Open

Question the need for H_np and U_np #60

dngoldberg opened this issue Feb 26, 2022 · 1 comment
Assignees
Labels

Comments

@dngoldberg
Copy link
Collaborator

dngoldberg commented Feb 26, 2022

In solver/timestep(), H_np and U_np are assigned to H and U after they are updated (this is an operation which must be annotated). U_np and H_np are used to define the RHS in def_thickadv_eq(). They do not seem to serve any other purpose (other than that sometimes diagnostic output uses U_np and H_np). Looking over model.py does not seem to contradict this (though possibly they are necessary for operations in the runs/ folder).

Are they necessary, and if not, is it an issue to keep them (or could it lead to potential confusion)?

If they are necessary for forming the RHS in def_thickadv_eq(), there is an inconsistency in line 515:

fl_ex = self.float_conditional(H)

since fl_ex is used in the RHS definition (at line 549).

@jrmaddison
Copy link
Collaborator

jrmaddison commented Feb 28, 2022

It seems these can be removed -- see #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants