Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance issues in the difinition of generate_initial_memories, nematus/transformer_inference.py #123

Open
DLPerf opened this issue Aug 12, 2021 · 1 comment
Open

Performance issues in the difinition of generate_initial_memories, nematus/transformer_inference.py #123

DLPerf opened this issue Aug 12, 2021 · 1 comment

Comments

@DLPerf
Copy link

DLPerf commented Aug 12, 2021

Hello, I found two performance issues in the definition of generate_initial_memories, nematus/transformer_inference.py, tf.zeros in line 133 and 135 will be calculated repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop in generate_initial_memories.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.
@rsennrich
Copy link
Collaborator

thank you for this report. I'm happy to accept PRs that improve efficiency.

@DLPerf DLPerf mentioned this issue Aug 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rsennrich @DLPerf