From 44f47e3556d76e9f63e683ef2ca44400a93b42a1 Mon Sep 17 00:00:00 2001
From: Peter Stadler <stadlerpeter@yahoo.fr>
Date: Thu, 12 Jan 2023 17:12:38 +0100
Subject: [PATCH] fix missing wikidata id pattern

Signed-off-by: Peter Stadler <stadlerpeter@yahoo.fr>
---
 compiled-ODD/guidelines-de-wegaPlaces.compiled.xml | 9 ++++++++-
 schema/de/wegaPlaces.rng                           | 9 +++++++--
 schema/en/wegaPlaces.rng                           | 9 +++++++--
 src/Specs/common-specs.odd.xml                     | 2 +-
 4 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/compiled-ODD/guidelines-de-wegaPlaces.compiled.xml b/compiled-ODD/guidelines-de-wegaPlaces.compiled.xml
index 792087e..cb6f48f 100644
--- a/compiled-ODD/guidelines-de-wegaPlaces.compiled.xml
+++ b/compiled-ODD/guidelines-de-wegaPlaces.compiled.xml
@@ -6204,7 +6204,7 @@ psychological significance.
     <ref target="https://www.tei-c.org/release/doc/tei-p5-doc/en/html/HD.html#HD27">2.2.6. The Notes Statement</ref>
     <ref target="https://www.tei-c.org/release/doc/tei-p5-doc/en/html/CO.html#COBICON">3.12.2.8. Notes and Statement of Language</ref>
     <ref target="https://www.tei-c.org/release/doc/tei-p5-doc/en/html/DI.html#DITPNO">9.3.5.4. Notes within Entries</ref>
-  </listRef></elementSpec><elementSpec xmlns:xi="http://www.w3.org/2001/XInclude" rend="change" module="header" ident="idno"><gloss xmlns:tei="http://www.tei-c.org/ns/1.0" xmlns:mei="http://www.music-encoding.org/ns/mei" xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0" xmlns:s="http://www.ascc.net/xml/schematron" rend="replace" versionDate="2013-11-11" xml:lang="en">identifier</gloss><gloss xmlns:tei="http://www.tei-c.org/ns/1.0" xmlns:mei="http://www.music-encoding.org/ns/mei" xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0" xmlns:s="http://www.ascc.net/xml/schematron" rend="replace" versionDate="2013-11-11" xml:lang="de">Bezeichner</gloss><desc xmlns:tei="http://www.tei-c.org/ns/1.0" xmlns:mei="http://www.music-encoding.org/ns/mei" xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0" xmlns:s="http://www.ascc.net/xml/schematron" rend="replace" versionDate="2013-11-11" xml:lang="en">supplies any form of identifier used to identify some object, such as a bibliographic item, a person, a title, an organization, etc. in a standardized way.</desc><desc xmlns:tei="http://www.tei-c.org/ns/1.0" xmlns:mei="http://www.music-encoding.org/ns/mei" xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0" xmlns:s="http://www.ascc.net/xml/schematron" rend="replace" versionDate="2013-11-11" xml:lang="de">lieferte jegliche Form eines Bezeichners in einer standardisierten Form, der benutzt werden kann um Objekte zu identifiziert, wie etwa ein bibliographisches Element, eine Organisation, usw.</desc><classes><memberOf key="att.datable"/><memberOf key="att.typed"/><memberOf key="model.nameLike"/></classes><content><choice xmlns="http://relaxng.org/ns/structure/1.0"><ref name="pnd.pattern"/><ref name="viaf.pattern"/><ref name="bd.pattern"/><ref name="geonames.pattern"/><ref name="geonames.pattern"/></choice></content><constraintSpec xmlns:tei="http://www.tei-c.org/ns/1.0" xmlns:mei="http://www.music-encoding.org/ns/mei" xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0" xmlns:s="http://www.ascc.net/xml/schematron" scheme="schematron" ident="types-match-external-identifiers">
+  </listRef></elementSpec><elementSpec xmlns:xi="http://www.w3.org/2001/XInclude" rend="change" module="header" ident="idno"><gloss xmlns:tei="http://www.tei-c.org/ns/1.0" xmlns:mei="http://www.music-encoding.org/ns/mei" xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0" xmlns:s="http://www.ascc.net/xml/schematron" rend="replace" versionDate="2013-11-11" xml:lang="en">identifier</gloss><gloss xmlns:tei="http://www.tei-c.org/ns/1.0" xmlns:mei="http://www.music-encoding.org/ns/mei" xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0" xmlns:s="http://www.ascc.net/xml/schematron" rend="replace" versionDate="2013-11-11" xml:lang="de">Bezeichner</gloss><desc xmlns:tei="http://www.tei-c.org/ns/1.0" xmlns:mei="http://www.music-encoding.org/ns/mei" xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0" xmlns:s="http://www.ascc.net/xml/schematron" rend="replace" versionDate="2013-11-11" xml:lang="en">supplies any form of identifier used to identify some object, such as a bibliographic item, a person, a title, an organization, etc. in a standardized way.</desc><desc xmlns:tei="http://www.tei-c.org/ns/1.0" xmlns:mei="http://www.music-encoding.org/ns/mei" xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0" xmlns:s="http://www.ascc.net/xml/schematron" rend="replace" versionDate="2013-11-11" xml:lang="de">lieferte jegliche Form eines Bezeichners in einer standardisierten Form, der benutzt werden kann um Objekte zu identifiziert, wie etwa ein bibliographisches Element, eine Organisation, usw.</desc><classes><memberOf key="att.datable"/><memberOf key="att.typed"/><memberOf key="model.nameLike"/></classes><content><choice xmlns="http://relaxng.org/ns/structure/1.0"><ref name="pnd.pattern"/><ref name="viaf.pattern"/><ref name="bd.pattern"/><ref name="wikidata.id.pattern"/><ref name="geonames.pattern"/></choice></content><constraintSpec xmlns:tei="http://www.tei-c.org/ns/1.0" xmlns:mei="http://www.music-encoding.org/ns/mei" xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0" xmlns:s="http://www.ascc.net/xml/schematron" scheme="schematron" ident="types-match-external-identifiers">
                 <desc xml:lang="en" versionDate="2019-07-08">assert that provided ID matches the external identifier's pattern for IDs.</desc>
                 <desc xml:lang="de" versionDate="2019-07-08">überprüfe die gegebene ID mit dem Muster für externe Identifikatoren</desc>
                 <constraint>
@@ -6895,6 +6895,13 @@ psychological significance.
                     <rng:param name="pattern">wega:A09\d{4}</rng:param>
                 </rng:data>
             </content>
+        </macroSpec><macroSpec rend="add" ident="wikidata.id.pattern" mode="add" module="wega.core.module">
+            <content xmlns:tei="http://www.tei-c.org/ns/1.0" xmlns:mei="http://www.music-encoding.org/ns/mei" xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0" xmlns:s="http://www.ascc.net/xml/schematron">
+                <rng:data type="string">
+                    
+                    <rng:param name="pattern">Q[1-9]\d*</rng:param>
+                </rng:data>
+            </content>
         </macroSpec><constraintSpec xmlns:tei="http://www.tei-c.org/ns/1.0" xmlns:mei="http://www.music-encoding.org/ns/mei" xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0" xmlns:s="http://www.ascc.net/xml/schematron" scheme="schematron" ident="styleguide-document-node-content">
             <constraint>
                 <sch:rule context="document-node()">
diff --git a/schema/de/wegaPlaces.rng b/schema/de/wegaPlaces.rng
index c21f580..4bd760a 100644
--- a/schema/de/wegaPlaces.rng
+++ b/schema/de/wegaPlaces.rng
@@ -5,7 +5,7 @@
          xmlns="http://relaxng.org/ns/structure/1.0"
          datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes"
          ns="http://www.tei-c.org/ns/1.0"><!--
-Schema generated from ODD source 2023-01-12T15:50:18Z. .
+Schema generated from ODD source 2023-01-12T16:10:53Z. .
 TEI Edition: Version 4.5.0. Last updated on
         25th October 2022, revision 3e98e619e
 TEI Edition Location: https://www.tei-c.org/Vault/P5/Version 4.5.0/
@@ -79,6 +79,11 @@ TEI Edition Location: https://www.tei-c.org/Vault/P5/Version 4.5.0/
          <param name="pattern">wega:A09\d{4}</param>
       </data>
    </define>
+   <define name="wikidata.id.pattern">
+      <data type="string">
+         <param name="pattern">Q[1-9]\d*</param>
+      </data>
+   </define>
    <define name="att.ascribed.attributes">
       <ref name="att.ascribed.attribute.who"/>
    </define>
@@ -2714,7 +2719,7 @@ Empfohlene Werte sind: 1] deprecationInfo (deprecation information)</a:documenta
             <ref name="pnd.pattern"/>
             <ref name="viaf.pattern"/>
             <ref name="bd.pattern"/>
-            <ref name="geonames.pattern"/>
+            <ref name="wikidata.id.pattern"/>
             <ref name="geonames.pattern"/>
          </choice>
          <pattern xmlns="http://purl.oclc.org/dsdl/schematron"
diff --git a/schema/en/wegaPlaces.rng b/schema/en/wegaPlaces.rng
index 3fa1739..7b76b6d 100644
--- a/schema/en/wegaPlaces.rng
+++ b/schema/en/wegaPlaces.rng
@@ -5,7 +5,7 @@
          xmlns="http://relaxng.org/ns/structure/1.0"
          datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes"
          ns="http://www.tei-c.org/ns/1.0"><!--
-Schema generated from ODD source 2023-01-12T15:50:32Z. .
+Schema generated from ODD source 2023-01-12T16:10:56Z. .
 TEI Edition: Version 4.5.0. Last updated on
         25th October 2022, revision 3e98e619e
 TEI Edition Location: https://www.tei-c.org/Vault/P5/Version 4.5.0/
@@ -79,6 +79,11 @@ TEI Edition Location: https://www.tei-c.org/Vault/P5/Version 4.5.0/
          <param name="pattern">wega:A09\d{4}</param>
       </data>
    </define>
+   <define name="wikidata.id.pattern">
+      <data type="string">
+         <param name="pattern">Q[1-9]\d*</param>
+      </data>
+   </define>
    <define name="att.ascribed.attributes">
       <ref name="att.ascribed.attribute.who"/>
    </define>
@@ -2714,7 +2719,7 @@ Suggested values include: 1] deprecationInfo (deprecation information)</a:docume
             <ref name="pnd.pattern"/>
             <ref name="viaf.pattern"/>
             <ref name="bd.pattern"/>
-            <ref name="geonames.pattern"/>
+            <ref name="wikidata.id.pattern"/>
             <ref name="geonames.pattern"/>
          </choice>
          <pattern xmlns="http://purl.oclc.org/dsdl/schematron"
diff --git a/src/Specs/common-specs.odd.xml b/src/Specs/common-specs.odd.xml
index 0d16dea..27c518b 100644
--- a/src/Specs/common-specs.odd.xml
+++ b/src/Specs/common-specs.odd.xml
@@ -4239,7 +4239,7 @@
                     <rng:ref name="pnd.pattern"/>
                     <rng:ref name="viaf.pattern"/>
                     <rng:ref name="bd.pattern"/>
-                    <rng:ref name="geonames.pattern"/>
+                    <rng:ref name="wikidata.id.pattern"/>
                     <rng:ref name="geonames.pattern"/>
                 </rng:choice>
             </content>