From 8c8d54d455abe82d31675a10aeb0c6798cd9e654 Mon Sep 17 00:00:00 2001 From: Edmond Chui Date: Thu, 17 Oct 2024 11:54:00 -0700 Subject: [PATCH] add appId to Telemetry (#47099) Summary: Changelog: [Internal] As discussed in D64547367, recent changes caused `description` to stop reporting `appId`. This impacted Telemetry's "top apps" dashboards. {F1936011487} Reviewed By: hoxyq Differential Revision: D64548348 --- packages/dev-middleware/src/middleware/openDebuggerMiddleware.js | 1 + packages/dev-middleware/src/types/EventReporter.js | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/dev-middleware/src/middleware/openDebuggerMiddleware.js b/packages/dev-middleware/src/middleware/openDebuggerMiddleware.js index 490eb5d91f80b7..e10a3a9f5e2069 100644 --- a/packages/dev-middleware/src/middleware/openDebuggerMiddleware.js +++ b/packages/dev-middleware/src/middleware/openDebuggerMiddleware.js @@ -156,6 +156,7 @@ export default function openDebuggerMiddleware({ appId: appId ?? null, deviceId: device ?? null, resolvedTargetDescription: target.description, + resolvedTargetAppId: target.appId, prefersFuseboxFrontend: useFuseboxEntryPoint ?? false, }); return; diff --git a/packages/dev-middleware/src/types/EventReporter.js b/packages/dev-middleware/src/types/EventReporter.js index f578f745cf3a6f..8c4bc2b52aed49 100644 --- a/packages/dev-middleware/src/types/EventReporter.js +++ b/packages/dev-middleware/src/types/EventReporter.js @@ -41,6 +41,7 @@ export type ReportableEvent = appId: string | null, deviceId: string | null, resolvedTargetDescription: string, + resolvedTargetAppId: string, prefersFuseboxFrontend: boolean, }> | ErrorResult