Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enemy Killed Animation #54

Open
EdwardDunn opened this issue Oct 17, 2017 · 4 comments
Open

Enemy Killed Animation #54

EdwardDunn opened this issue Oct 17, 2017 · 4 comments

Comments

@EdwardDunn
Copy link
Owner

EdwardDunn commented Oct 17, 2017

Enemy Killed Animation

Currently when the player character jumps on an enemy character it falls off the screen.

Create an animation that makes the enemy character explode instead of falling away every time there is a collision.

There are a number of JQuery plugins to help with sprite animation.

@skywalker212
Copy link

can we add a dissolving or fading effect?

@antoschd
Copy link
Contributor

@EdwardDunn since we are jumping on the enemies, why not squeeze them and make them fall to the ground? This can be done, quit simple, by changing height and using the function hitBottom. I can do a pull-request if you like to.
animation
awesome first game, by the way!

@sseelbach
Copy link

sseelbach commented Oct 23, 2017

I don't think you can easily use the Jquery animation tools typical for CSS animation since the sprites are using the Canvas object - antoschd probably has the easiest method.

I couldn't find anything that felt like a cool death animation here:
https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Advanced_animations

@EdwardDunn
Copy link
Owner Author

@antoschd Great idea, Its nice and simple but really adds to the game play. If other contributors want to create a more advanced animation that is fine but this is a good start. Go ahead and create a PR for your change.

I will keep this issue open for anyone who wants to keep working on animations.

antoschd added a commit to antoschd/Platform-Game that referenced this issue Oct 23, 2017
setting height to a third of original and drop enemy to the ground if dead

EdwardDunn#54
antoschd added a commit to antoschd/Platform-Game that referenced this issue Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants