Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase automated test coverage to 100% #28

Open
AndyGaskell opened this issue Jul 30, 2020 · 0 comments
Open

Increase automated test coverage to 100% #28

AndyGaskell opened this issue Jul 30, 2020 · 0 comments
Labels

Comments

@AndyGaskell
Copy link
Collaborator

Think we just need 2 more tests to increase automated test coverage to 100%.

It's at 98.9% at the moment on https://coveralls.io/github/EdwinHoksberg/php-fcm

Add a test that passes data param into the constructor...
https://coveralls.io/builds/32427333/source?filename=src/Push/Notification.php#L69

Add a test to test exception catching when passing a non-array into the addDataArray function...
https://coveralls.io/builds/32427333/source?filename=src/Push/Push.php#L69

This is not an issue really, just a reminder to myself as much as anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant