-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect the default for a text prompt #3466
Conversation
🦋 Changeset detectedLatest commit: 338e718 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cdierkens - just a few tiny additional comments. Otherwise everything looks good. Once you make these additional changes, I'll trigger CI and as long as everything passes we can get this merged 👍
@cdierkens - looks like there are some linting issues. If you run |
@IMax153 Done and done. |
Type
Description
This PR respects the default value passed in when creating a
Example
Warning
I attempted to model the
Wizard
tests, but could not get theEnter
key to effect the program exit.Related
Prompt.text
from @effect/cli has no effect. #3465