Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check back on FFXIV fish sanity #47

Open
Eijebong opened this issue Feb 5, 2025 · 2 comments
Open

Check back on FFXIV fish sanity #47

Eijebong opened this issue Feb 5, 2025 · 2 comments

Comments

@Eijebong
Copy link
Owner

Eijebong commented Feb 5, 2025

silasary/APxiv#6 changes the option to a choice
@Eijebong
Copy link
Owner Author

Eijebong commented Feb 8, 2025

Because the choice has 0 as fishsanity disabled, and positive numbers as it enabled, we don't even have to change anything

@Eijebong Eijebong closed this as completed Feb 8, 2025
@Eijebong Eijebong reopened this Feb 9, 2025
@Eijebong
Copy link
Owner Author

Eijebong commented Feb 9, 2025

Turns out that some text is also valid,

KeyError: 'Could not find option "true" for "Fishsanity", known options are disabled, normal_fish, timed_fish, big_fish'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Eijebong