diff --git a/NewRadX/configuration.ccl b/NewRadX/configuration.ccl index 02aa190b..c7ecf00a 100644 --- a/NewRadX/configuration.ccl +++ b/NewRadX/configuration.ccl @@ -5,5 +5,3 @@ REQUIRES Loop PROVIDES NewRadX { } - -REQUIRES NewRadX diff --git a/Z4c/param.ccl b/Z4c/param.ccl index aadc52a3..849de638 100644 --- a/Z4c/param.ccl +++ b/Z4c/param.ccl @@ -58,6 +58,46 @@ CCTK_REAL epsdiss "Dissipation coefficient " STEERABLE=alwa } 0.32 KEYWORD boundary_conditions "boundary conditions"{ - "radiative" :: "radiative boundary conditions using NewRadX" - "CarpetX" :: "use CarpetX default boundary conditions" + "NewRadX" :: "radiative boundary conditions using NewRadX" + "CarpetX" :: "use CarpetX default boundary conditions" } "CarpetX" + +CCTK_INT n_chi "n power of outgoing boundary r^n fall off rate for chi" +{ + 0:2 :: "1 is reasonable" +} 1 + +CCTK_INT n_gammat "n power of outgoing boundary r^n fall off rate for gammat_ij" +{ + 0:2 :: "1 is reasonable" +} 1 + +CCTK_INT n_Kh "n power of outgoing boundary r^n fall off rate for Kh" +{ + 0:2 :: "Maybe 1?" +} 1 + +CCTK_INT n_At "n power of outgoing boundary r^n fall off rate for At_ij" +{ + 0:2 :: "Maybe 1?" +} 1 + +CCTK_INT n_Gamt "n power of outgoing boundary r^n fall off rate for Gamt^i" +{ + 0:2 :: "Maybe 1?" +} 1 + +CCTK_INT n_Theta "n power of outgoing boundary r^n fall off rate for Theta" +{ + 0:2 :: "Maybe 1?" +} 1 + +CCTK_INT n_alphaG "n power of outgoing boundary r^n fall off rate for alpha" +{ + 0:2 :: "1 is my guess" +} 1 + +CCTK_INT n_betaG "n power of outgoing boundary r^n fall off rate for beta" +{ + 0:2 :: "1 is my guess" +} 1 diff --git a/Z4c/schedule.ccl b/Z4c/schedule.ccl index f1257291..b748ec45 100644 --- a/Z4c/schedule.ccl +++ b/Z4c/schedule.ccl @@ -257,8 +257,8 @@ SCHEDULE Z4c_RHS IN Z4c_RHSGroup SYNC: betaG_rhs } "Calculate Z4c RHS" -if (CCTK_Equals(boundary_conditions, "radiative")) { - SCHEDULE apply_boundary_conditions IN Z4c_RHSGroup AFTER Z4c_RHS +if (CCTK_Equals(boundary_conditions, "NewRadX")) { + SCHEDULE Z4c_apply_newradx_boundary_conditions IN Z4c_RHSGroup AFTER Z4c_RHS { LANG: C READS: chi(everywhere) @@ -285,5 +285,5 @@ if (CCTK_Equals(boundary_conditions, "radiative")) { WRITES: Theta_rhs(interior) WRITES: alphaG_rhs(interior) WRITES: betaG_rhs(interior) - } "Apply NewRad boundary conditions to Z4c RHS variables" + } "Apply radiative boundary conditions to Z4c RHS variables using NewRadX" } diff --git a/Z4c/src/apply_newrad.cxx b/Z4c/src/apply_newrad.cxx index ec9d1b70..10dc9662 100644 --- a/Z4c/src/apply_newrad.cxx +++ b/Z4c/src/apply_newrad.cxx @@ -10,32 +10,32 @@ using namespace NewRadX; namespace Z4c { -extern "C" void apply_boundary_conditions(CCTK_ARGUMENTS) { - DECLARE_CCTK_ARGUMENTSX_apply_boundary_conditions; +extern "C" void Z4c_apply_newradx_boundary_conditions(CCTK_ARGUMENTS) { + DECLARE_CCTK_ARGUMENTSX_Z4c_apply_newradx_boundary_conditions; DECLARE_CCTK_PARAMETERS; - NewRadX_Apply(cctkGH, chi, chi_rhs, 1, 1, 1); - NewRadX_Apply(cctkGH, gammatxx, gammatxx_rhs, 1, 1, 1); - NewRadX_Apply(cctkGH, gammatxy, gammatxy_rhs, 0, 1, 1); - NewRadX_Apply(cctkGH, gammatxz, gammatxz_rhs, 0, 1, 1); - NewRadX_Apply(cctkGH, gammatyy, gammatyy_rhs, 1, 1, 1); - NewRadX_Apply(cctkGH, gammatyz, gammatyz_rhs, 0, 1, 1); - NewRadX_Apply(cctkGH, gammatzz, gammatzz_rhs, 1, 1, 1); - NewRadX_Apply(cctkGH, Kh, Kh_rhs, 0, 1, 1); - NewRadX_Apply(cctkGH, Atxx, Atxx_rhs, 0, 1, 1); - NewRadX_Apply(cctkGH, Atxy, Atxy_rhs, 0, 1, 1); - NewRadX_Apply(cctkGH, Atxz, Atxz_rhs, 0, 1, 1); - NewRadX_Apply(cctkGH, Atyy, Atyy_rhs, 0, 1, 1); - NewRadX_Apply(cctkGH, Atyz, Atyz_rhs, 0, 1, 1); - NewRadX_Apply(cctkGH, Atzz, Atzz_rhs, 0, 1, 1); - NewRadX_Apply(cctkGH, Gamtx, Gamtx_rhs, 0, 1, 1); - NewRadX_Apply(cctkGH, Gamty, Gamty_rhs, 0, 1, 1); - NewRadX_Apply(cctkGH, Gamtz, Gamtz_rhs, 0, 1, 1); - NewRadX_Apply(cctkGH, Theta, Theta_rhs, 0, 1, 1); - NewRadX_Apply(cctkGH, alphaG, alphaG_rhs, 1, 1, 1); - NewRadX_Apply(cctkGH, betaGx, betaGx_rhs, 0, 1, 1); - NewRadX_Apply(cctkGH, betaGy, betaGy_rhs, 0, 1, 1); - NewRadX_Apply(cctkGH, betaGz, betaGz_rhs, 0, 1, 1); + NewRadX_Apply(cctkGH, chi, chi_rhs, 1, 1, n_chi); + NewRadX_Apply(cctkGH, gammatxx, gammatxx_rhs, 1, 1, n_gammat); + NewRadX_Apply(cctkGH, gammatxy, gammatxy_rhs, 0, 1, n_gammat); + NewRadX_Apply(cctkGH, gammatxz, gammatxz_rhs, 0, 1, n_gammat); + NewRadX_Apply(cctkGH, gammatyy, gammatyy_rhs, 1, 1, n_gammat); + NewRadX_Apply(cctkGH, gammatyz, gammatyz_rhs, 0, 1, n_gammat); + NewRadX_Apply(cctkGH, gammatzz, gammatzz_rhs, 1, 1, n_gammat); + NewRadX_Apply(cctkGH, Kh, Kh_rhs, 0, 1, n_Kh); + NewRadX_Apply(cctkGH, Atxx, Atxx_rhs, 0, 1, n_At); + NewRadX_Apply(cctkGH, Atxy, Atxy_rhs, 0, 1, n_At); + NewRadX_Apply(cctkGH, Atxz, Atxz_rhs, 0, 1, n_At); + NewRadX_Apply(cctkGH, Atyy, Atyy_rhs, 0, 1, n_At); + NewRadX_Apply(cctkGH, Atyz, Atyz_rhs, 0, 1, n_At); + NewRadX_Apply(cctkGH, Atzz, Atzz_rhs, 0, 1, n_At); + NewRadX_Apply(cctkGH, Gamtx, Gamtx_rhs, 0, 1, n_Gamt); + NewRadX_Apply(cctkGH, Gamty, Gamty_rhs, 0, 1, n_Gamt); + NewRadX_Apply(cctkGH, Gamtz, Gamtz_rhs, 0, 1, n_Gamt); + NewRadX_Apply(cctkGH, Theta, Theta_rhs, 0, 1, n_Theta); + NewRadX_Apply(cctkGH, alphaG, alphaG_rhs, 1, 1, n_alphaG); + NewRadX_Apply(cctkGH, betaGx, betaGx_rhs, 0, 1, n_betaG); + NewRadX_Apply(cctkGH, betaGy, betaGy_rhs, 0, 1, n_betaG); + NewRadX_Apply(cctkGH, betaGz, betaGz_rhs, 0, 1, n_betaG); } } // namespace Z4c diff --git a/Z4c/test/qc0.par b/Z4c/test/qc0.par index da484fe4..dfea077f 100644 --- a/Z4c/test/qc0.par +++ b/Z4c/test/qc0.par @@ -96,7 +96,7 @@ Z4c::calc_constraints = yes Z4c::chi_floor = 1.0e-6 Z4c::alphaG_floor = 1.0e-8 Z4c::epsdiss = 0.32 -Z4c::boundary_conditions = "radiative" +Z4c::boundary_conditions = "NewRadX" IO::out_dir = $parfile IO::out_every = 1 diff --git a/Z4c/test/qc0/performance.yaml b/Z4c/test/qc0/performance.yaml deleted file mode 100644 index bf1b2e78..00000000 --- a/Z4c/test/qc0/performance.yaml +++ /dev/null @@ -1,19 +0,0 @@ -performance: - 1: - evolution-seconds: 0.549288 - evolution-compute-seconds: 0.542746 - evolution-output-seconds: 0.00654221 - evolution-cell-updates: 55296 - evolution-iterations: 1 - 2: - evolution-seconds: 1.09821 - evolution-compute-seconds: 1.0849 - evolution-output-seconds: 0.0133092 - evolution-cell-updates: 110592 - evolution-iterations: 2 - 3: - evolution-seconds: 1.64971 - evolution-compute-seconds: 1.62906 - evolution-output-seconds: 0.0206463 - evolution-cell-updates: 165888 - evolution-iterations: 3 diff --git a/Z4c/test/test.ccl b/Z4c/test/test.ccl deleted file mode 100644 index b983cf78..00000000 --- a/Z4c/test/test.ccl +++ /dev/null @@ -1,5 +0,0 @@ -#Following settings are adopted for all tests: - -NPROCS 1 -ABSTOL 1e-8 -RELTOL 1e-8