diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1ac8b4b4..c07c388a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,7 +3,8 @@ name: CI # Control when the workflow will run on: push: - pull_request: + # `pull_request` is disabled because we already build for all pushes + # pull_request: # Allow running this workflow manually from the Actions tab workflow_dispatch: @@ -22,6 +23,7 @@ jobs: mode: [debug, optimize] exclude: - {accelerator: rocm, real-precision: real32} + - {accelerator: rocm, mode: debug} # uses too much memory? - {real-precision: real32, mode: optimize} env: ACCELERATOR: ${{matrix.accelerator}} @@ -37,12 +39,6 @@ jobs: # Check out the repository under $GITHUB_WORKSPACE, so our job can access it - uses: actions/checkout@v4 - # # Check out the documentation and test results - # - uses: actions/checkout@v3 - # with: - # ref: gh-pages - # path: gh-pages - - name: Log the triggering commit run: echo ${{github.event.client_payload.trigger}} @@ -51,14 +47,8 @@ jobs: - name: Build Cactus run: /bin/bash $GITHUB_WORKSPACE/scripts/build.sh - + - name: Test Cactus - # We cannot run with cuda nor with rocm. Debug builds run too slowly. - if: ${{matrix.accelerator == 'cpu' && matrix.mode == 'optimize'}} + # We cannot run on accelerators. Single precision output is not accurate enough. Debug builds run too slowly. + if: ${{matrix.accelerator == 'cpu' && matrix.real-precision == 'real64' && matrix.mode == 'optimize'}} run: /bin/bash $GITHUB_WORKSPACE/scripts/test.sh - - # Set exit code based on test status - - name: Set exit code - # Only look at the test results for `carpetx-cpu-real64` runs - if: ${{matrix.accelerator == 'cpu' && matrix.real-precision == 'real64' && matrix.mode == 'optimize' && env.TESTS_FAILED == 'True'}} - run: exit 1