Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store.py assumes that "master" is the code branch to work on #56

Open
rhaas80 opened this issue Feb 21, 2023 · 0 comments
Open

store.py assumes that "master" is the code branch to work on #56

rhaas80 opened this issue Feb 21, 2023 · 0 comments
Labels
minor bug something is wrong but does not directly affect main functionality

Comments

@rhaas80
Copy link
Member

rhaas80 commented Feb 21, 2023

Right now

tests/store.py

Line 107 in b8c4371

def store_commit_id(version):
still assumes that the branch we are working on is "master".

This will not always be the case (eg "main" or "trunk" could be used or even "devel").

Instead the HEAD commit should be obtained from (the pygit2 equivalent) of

id = os.popen(f"git --git-dir {REPO}/.git rev-parse HEAD").read().strip())
with open(dst,"w") as fh:
    print(id, file=fh)
@rhaas80 rhaas80 added the minor bug something is wrong but does not directly affect main functionality label Mar 16, 2023
nadinekuo pushed a commit to nadinekuo/einstein-toolkit-tests that referenced this issue Mar 29, 2023
Submodule repos/nrpytutorial 44665ed..b60bba2:
  > Merge pull request EinsteinToolkit#56 from zachetienne/scupp/BaikalRDWR
Submodule repos/wvuthorns 0cb4d23..55b8066:
  > Merged in scupp/BaikalRDWR (pull request EinsteinToolkit#13)
einsteintoolkit-updater pushed a commit that referenced this issue Mar 29, 2023
Submodule repos/nrpytutorial 44665ed..b60bba2:
  > Merge pull request #56 from zachetienne/scupp/BaikalRDWR
Submodule repos/wvuthorns 0cb4d23..55b8066:
  > Merged in scupp/BaikalRDWR (pull request #13)
einsteintoolkit-updater pushed a commit that referenced this issue Oct 28, 2023
Submodule repos/GRHayL fc5707f..f7dd5fc:
  > Added Noble1D unit test (#56)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor bug something is wrong but does not directly affect main functionality
Projects
None yet
Development

No branches or pull requests

1 participant