-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Migrate CLI print methods to single module #601
Comments
Hello my name is Antonio and I would like to contribute to this issue along with my two peers, Pedro and Justice. |
Hey, I'm Pedro Rangel, and I will be part of the team. |
Hello my name is Justice and I would like to help contribute to this issue along with Antonio, and Pedro. |
welcome @JKnight777 @CodingForFun-coder and @Alopezjr2002 welcome aboard! Please have at it and use this issue for any questions and comments. I'll also send you invites to the Democracy Forward slack |
Is there an existing issue for this?
Suggestion
To improve the CLI and be a bit more pythonic, migrate the common click to echo to a more aptly named module. Ideally, this should contain the references to
click.echo
to a single module, but the closest to this is best.Possible Implementation
Create a
print_utils.py
file in theelectionguard_cli
to be used for all print functionality. These should all be methods and no classes should be necessary. This should allow the deletion ofe2estepbase.py
Suggested items to migrate:
https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/input_retrieval_step.py#L42
https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/e2e_step_base.py#L14
https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/e2e_step_base.py#L19
https://github.com/microsoft/electionguard-python/blob/03698c683ab35f608e35dc9b66217caa1d40f7eb/src/electionguard_cli/e2e_steps/print_results_step.py#L13
Anything else?
No response
The text was updated successfully, but these errors were encountered: