Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Change branch trigger, fix test, run tests in CI #15

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

spencerwilson
Copy link

@spencerwilson spencerwilson commented Jan 28, 2022

Issue

Fixes #13
Fixes #14

Description

  • Sort different types of JSON artifacts into different directories, allowing the deserialization test to address just the artifacts it ought to
  • Replace rustbuild.yml with the Rust starter workflow, which 1) restores PR triggering, 2) adds main branch triggering, 3) adds test running
  • Rename GitHub Actions workflow "Linux Build Rust" -> "CI" (IMO simpler and yet more descriptive)

I suspect #14 was a regression introduced in f470d12, which added an Election JSON artifact to a directory that otherwise only contained Record artifacts.

Testing

CI!

Checklist

🚨Please review the guidelines for contributing to this repository.

  • 🤔 CONSIDER adding a unit test if your PR resolves an issue.
  • DO check open PR's to avoid duplicates.
  • DO keep pull requests small so they can be easily reviewed.
  • DO build locally before pushing.
  • DO make sure tests pass.
  • DO make sure any new changes are documented.
  • DO make sure not to introduce any compiler warnings.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

💔Thank you!

@ghost
Copy link

ghost commented Jan 28, 2022

CLA assistant check
All CLA requirements met.

@spencerwilson spencerwilson changed the title ci: Change branch trigger, fix test, re-enable tests ci: Change branch trigger, fix test, run tests in CI Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_parsing fails CI workflow doesn't trigger on PRs
1 participant