Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🗂 Write In is nullable field in Manifest #221

Open
1 task done
keithrfung opened this issue Feb 16, 2022 · 0 comments
Open
1 task done

🗂 Write In is nullable field in Manifest #221

keithrfung opened this issue Feb 16, 2022 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@keithrfung
Copy link
Collaborator

keithrfung commented Feb 16, 2022 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Suggestion

The Manifest particularly Manifest.Candidate.is_write_in is encoded as null or true or false since it is an Optional[boolean] at least in Python.

Possible Implementation

Recommend approach would be to replace this field with only true or false and make it mandatory.

Anything else?

Original Issues in Python from @JohnLCaron
Election-Tech-Initiative/electionguard-python#532
Election-Tech-Initiative/electionguard-python#522
Election-Tech-Initiative/electionguard-python#523
@keithrfung keithrfung added enhancement New feature or request triage Waiting to be triaged labels Feb 16, 2022
@keithrfung keithrfung changed the title ✨ Write In is nullable field in Manifest 🗂 Write In is nullable field in Manifest Feb 16, 2022
@keithrfung keithrfung added question Further information is requested and removed triage Waiting to be triaged labels May 13, 2022
shreyasminocha added a commit to danwallach/ElectionGuard-TypeScript that referenced this issue Jun 29, 2022
@shreyasminocha
Match write-in field serialization
5937b35 
Necessary until Election-Tech-Initiative/electionguard#221 is resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@keithrfung