Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Remove the VoteVariationTypes not supported in 1.0 library #245

Open
1 task done
JohnLCaron opened this issue Mar 15, 2022 · 1 comment
Open
1 task done

✨ Remove the VoteVariationTypes not supported in 1.0 library #245

JohnLCaron opened this issue Mar 15, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@JohnLCaron
Copy link
Collaborator

JohnLCaron commented Mar 15, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Suggestion

AFAICT, the 1.0 reference library supports

  1. n_of_m type election
  2. one_of_m is a special case with number_elected = 1.
  3. approval where votes_allowed = number of options.

I think in these three cases votes_allowed == number_elected.

Im looking at the other VoteVariationType's, and Im guessing some of those (majority, plurality, proportional, super_majority) can be done by the current system because they are just special versions of n_of_m. Some (borda, cumulative, range, rcv) I guess cannot currently be done.

For clarity, we should remove the VoteVariationTypes not supported in the 1.0 library, and for the supported ones, make clear if election guard needs to do any special handling.

Possible Implementation

For 1.0, remove all VoteVariationType's except n_of_m, one_of_m, and approval. Remove number_elected and only use votes_allowed, which is required.

Anything else?

Also see Issue #224 and Discussion #247

@JohnLCaron JohnLCaron added enhancement New feature or request triage Waiting to be triaged labels Mar 15, 2022
@SteveMaier-IRT SteveMaier-IRT added question Further information is requested and removed triage Waiting to be triaged labels Mar 29, 2022
@colleenirt
Copy link
Collaborator

Python handles with an error in 1.0. CPP needs to be checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants