Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Height x is below sapling activation height #1595

Closed
HonzaR opened this issue Sep 26, 2024 · 0 comments · Fixed by #1596
Closed

BUG: Height x is below sapling activation height #1595

HonzaR opened this issue Sep 26, 2024 · 0 comments · Fixed by #1596
Labels
bug Something isn't working

Comments

@HonzaR
Copy link
Contributor

HonzaR commented Sep 26, 2024

Describe the issue

We have a user reporting a syncing problem that turned out to be our previously correct check, which is now incorrect after we introduced the Transparent history changes #1559.

After our internal discussion, we decided to remove such a check from the BlockHeight object creation.

require(blockHeight >= zcashNetwork.saplingActivationHeight.value) {
   "Height $blockHeight is below sapling activation height ${zcashNetwork.saplingActivationHeight}"
}

Can you reliably reproduce the issue?

No, we can't. The report came from the production app version.

Actual behavior + errors

java.lang.IllegalArgumentException: Height 397315 is below sapling activation height BlockHeight(value=419200)
at io.perfmark.Tag.new(SourceFile:4)
at kotlin.math.MathKt.toBlockHeight(Unknown Source:14)
at cash.z.ecc.android.sdk.block.processor.CompactBlockProcessor$Companion.access$enhanceTransaction(Unknown Source:282)
at cash.z.ecc.android.sdk.block.processor.CompactBlockProcessor$Companion$enhanceTransaction$1.invokeSuspend(Unknown Source:10)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(Unknown Source:8)
at kotlinx.coroutines.internal.ScopeCoroutine.afterResume(Unknown Source:6)
at kotlinx.coroutines.AbstractCoroutine.resumeWith(Unknown Source:22)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(Unknown Source:31)
at kotlinx.coroutines.DispatchedTask.run(Unknown Source:112)
at android.os.Handler.handleCallback(Handler.java:959)
at android.os.Handler.dispatchMessage(Handler.java:100)
at android.os.Looper.loopOnce(Looper.java:232)
at android.os.Looper.loop(Looper.java:317)
at android.app.ActivityThread.main(ActivityThread.java:8592)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:878)

  • App Version: Any
  • Android Version: Any
  • Device: (if applies) Any
@HonzaR HonzaR added the bug Something isn't working label Sep 26, 2024
HonzaR added a commit that referenced this issue Sep 26, 2024
- The check for sapling activation height inside the BlockHeight component is no longer correct
@HonzaR HonzaR linked a pull request Sep 26, 2024 that will close this issue
13 tasks
HonzaR added a commit that referenced this issue Sep 27, 2024
- The check for sapling activation height inside the BlockHeight component is no longer correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant