-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1511] Refactor account representation from int to a dedicated account structure #1515
Merged
LukasKorba
merged 7 commits into
Electric-Coin-Company:1514-Finish-multi-account-support
from
LukasKorba:1511-Refactor-account-representation-from-Int-to-a-dedicated-Account-structure
Nov 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to a dedicated Account structure - First iteration of all Int account references to an instance of an Account
- The ID of account is now public co clients can read-only it
- Zip32 accounts represented with Int32 are now refactored to Zip32Account - from_account_id/fto_account_id are now refactored to AccountId
pacu
reviewed
Nov 22, 2024
pacu
suggested changes
Nov 22, 2024
daira
reviewed
Nov 23, 2024
Example/ZcashLightClientSample/ZcashLightClientSample/Send/SendViewController.swift
Outdated
Show resolved
Hide resolved
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
Sources/ZcashLightClientKit/Block/Actions/SaplingParamsAction.swift
Outdated
Show resolved
Hide resolved
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
Sources/ZcashLightClientKit/Rust/ZcashKeyDerivationBackendWelding.swift
Outdated
Show resolved
Hide resolved
daira
reviewed
Nov 23, 2024
Sources/ZcashLightClientKit/Rust/ZcashKeyDerivationBackendWelding.swift
Outdated
Show resolved
Hide resolved
daira
reviewed
Nov 23, 2024
Sources/ZcashLightClientKit/Rust/ZcashKeyDerivationBackendWelding.swift
Outdated
Show resolved
Hide resolved
daira
reviewed
Nov 23, 2024
Sources/ZcashLightClientKit/Rust/ZcashKeyDerivationBackendWelding.swift
Outdated
Show resolved
Hide resolved
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
daira
reviewed
Nov 23, 2024
Tests/OfflineTests/DerivationToolTests/DerivationToolMainnetTests.swift
Outdated
Show resolved
Hide resolved
daira
reviewed
Nov 23, 2024
daira
requested changes
Nov 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested.
- Zip32Account(Int32) has been refactored to Zip32AccountIndex(UIn32)
- WalletSummary's accountBalances dictionary has been refactored to use Zip32AccountIndex instead of UInt32 for the keys
daira
reviewed
Nov 28, 2024
Sources/ZcashLightClientKit/Rust/ZcashKeyDerivationBackend.swift
Outdated
Show resolved
Hide resolved
daira
reviewed
Nov 28, 2024
Sources/ZcashLightClientKit/Rust/ZcashKeyDerivationBackend.swift
Outdated
Show resolved
Hide resolved
daira
reviewed
Nov 28, 2024
daira
reviewed
Nov 28, 2024
daira
reviewed
Nov 28, 2024
Sources/ZcashLightClientKit/Transaction/TransactionEncoder.swift
Outdated
Show resolved
Hide resolved
daira
reviewed
Nov 28, 2024
daira
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK with blocking comments.
- Some comments updated to reflect reality - Some Tests fixed
LukasKorba
merged commit Nov 29, 2024
670f2ce
into
Electric-Coin-Company:1514-Finish-multi-account-support
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1511
DerivationTool
uses accountIndex: Int32from_account_id
/to_account_id
refactored to AccountId(Int)This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer