Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated tests #29

Open
1 of 10 tasks
Armaldio opened this issue Nov 26, 2019 · 5 comments
Open
1 of 10 tasks

Automated tests #29

Armaldio opened this issue Nov 26, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Armaldio
Copy link
Member

Armaldio commented Nov 26, 2019

  • Electron
    • Linux 32 bits
    • Mac
    • Some errors
  • NW.js
    • Linux 32 bits
    • Linux 64 bits, <= 76
    • Windows
    • Mac
  • Node.js
@Armaldio Armaldio added the bug Something isn't working label Nov 26, 2019
@Armaldio Armaldio self-assigned this Nov 26, 2019
@Armaldio
Copy link
Member Author

32 bits builds are failing because greenworks.js require 64bits by default on 64 bits

@Armaldio Armaldio added enhancement New feature or request and removed bug Something isn't working labels Dec 12, 2019
@TheRealDannyyy
Copy link
Contributor

TheRealDannyyy commented Jan 28, 2020

@Armaldio Do you think you can at least get automatic NWjs Windows 32/64bit testing done, so we can get it out of beta? It's getting tedious to manually test builds.

@Armaldio
Copy link
Member Author

So, I just gave it a try again but that was unsuccessful.

  1. It's highly time-consuming and I have other things to do
  2. I lack nw.js knowledge (electron and node work in a standard way, so I made it, NW.js seems to work differently)
  3. I can automate testing only 64 bits

Is it still worth it ?

@TheRealDannyyy
Copy link
Contributor

If it works for Windows 64 bits. It's safe to assume it will work for the rest.
Just make sure to add a checkmark or something for tested releases on the website.

@Armaldio
Copy link
Member Author

It's either uploaded or not
For displaying info on the website, it will involve a database

@TheRealDannyyy TheRealDannyyy added this to the Stable - V1.1 milestone Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants