Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Damrum to sites #579

Closed
wants to merge 1 commit into from
Closed

Add Damrum to sites #579

wants to merge 1 commit into from

Conversation

zsomborfoldi
Copy link
Contributor

@zsomborfoldi zsomborfoldi commented Oct 30, 2024

Summary by Sourcery

New Features:

  • Added 'Damrum' to the list of sites in the Provenance domain.

Copy link
Contributor

sourcery-ai bot commented Oct 30, 2024

Reviewer's Guide by Sourcery

This PR adds a new site "Damrum" to the Provenance enum class, extending the list of supported archaeological sites in the system.

Updated class diagram for Provenance enum

classDiagram
    class Provenance {
        <<enumeration>>
        BAD_TIBIRA
        BORSIPPA
        CUTHA
        DAMRUM
        DILBAT
        DIQDIQQAH
        DUR_KURIGALZU
    }
    note for DAMRUM "New site added to the Provenance enum"
Loading

File-Level Changes

Change Details Files
Added a new archaeological site to the Provenance enumeration
  • Added Damrum site with its full name, abbreviation (Dam), region (Babylonia), and site code (DMRunk)
ebl/common/domain/provenance.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zsomborfoldi - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please use a 3-letter site code to maintain consistency with other entries. 'DMRunk' should be shortened to something like 'DMR'.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@zsomborfoldi zsomborfoldi deleted the New-provenances branch October 30, 2024 15:48
@ejimsan
Copy link
Member

ejimsan commented Nov 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants