Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garage door endposition #80

Closed
fel115 opened this issue Aug 31, 2023 · 3 comments
Closed

Garage door endposition #80

fel115 opened this issue Aug 31, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@fel115
Copy link
Collaborator

fel115 commented Aug 31, 2023

Is the garage door open if the endposition switch is reached or closed? Because the status says Closed and the message says Garage door closed..

opensesame/src/main.rs

Lines 518 to 529 in 5ede5a8

GarageChange::ReachedTorEndposition => {
nc.set_info_door(gettext("🔒 Open"));
nc.send_message(gettext!(
"🔒 Garage door closed. {}",
environment.to_string()
));
}
GarageChange::LeftTorEndposition => {
nc.set_info_door(gettext("🔓 Closed"));
nc.send_message(gettext!("🔓 Garage door open. {}", environment.to_string()));
}
}

@fel115 fel115 added the help wanted Extra attention is needed label Aug 31, 2023
@markus2330
Copy link
Contributor

The garage door is closed if the endpoint switch is closed.

You found a bug, great job! ❤️ 🚀

Both the set_info_door text (but not the symbol) is wrong.

@fel115 fel115 added bug Something isn't working and removed help wanted Extra attention is needed labels Aug 31, 2023
@markus2330 markus2330 assigned fel115 and unassigned markus2330 Oct 15, 2023
@markus2330
Copy link
Contributor

Maybe you already fixed it but I cannot check due to #106

@fel115
Copy link
Collaborator Author

fel115 commented Oct 16, 2023

should be fixed with PR #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants