Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dill and Apache Arrow directly for caching & storing hidden states #203

Open
norabelrose opened this issue Apr 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@norabelrose
Copy link
Member

Right now we save hidden states as a HF dataset so that we can use its magical caching abilities. We're clearly wrangling HF into supporting something it wasn't designed for and this does cause us to need to load the model from disk a bunch of times during a sweep, whereas we could load it only once if we had more control. I expect we could get at least a 2x speedup from this for large models, and the code could be cleaner. It would also remove the confusing "Downloading and preparing" messages that currently pop up when we extract hiddens

@norabelrose norabelrose added the enhancement New feature or request label Apr 19, 2023
@norabelrose
Copy link
Member Author

This is kinda low priority but would still like to do this at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant