From 18711c9217ef6421b155d367021ce5299f70ea4c Mon Sep 17 00:00:00 2001 From: EllaKaye <ella.kaye@gmail.com> Date: Thu, 29 Jun 2017 20:55:24 +0100 Subject: [PATCH] update cran comments --- cran-comments.md | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/cran-comments.md b/cran-comments.md index 959fee3..3752fb1 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -6,10 +6,21 @@ ## R CMD check results here were no ERRORs and no WARNINGs -There was one NOTE: +There was one NOTE on the local OS X and windows check: * checking CRAN incoming feasibility ... NOTE Maintainer: ‘Ella Kaye <E.Kaye.1@warwick.ac.uk>’ +There was one NOTE on the linux check (on Travis-CI): +* checking installed package size ... NOTE + installed size is 5.7Mb + sub-directories of 1Mb or more: + libs 5.4Mb + +This NOTE does not appear on the OS X or windows check. +Moreover, this NOTE also did not appear when checking on a local linux environment (using platform: i686-pc-linux-gnu (32-bit)) + +My understanding is that this inflation of the libs subdirectory is due to the use of Rcpp. Indeed, some functions of the BradleyTerryScalable package have been written in C++ using Rcpp. They are needed to fit the Bradley-Terry model to large datasets. Without the speed up gained from those C++ functions, this package would not be fit for purpose. + New submission ## First submission