Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Downloading audio tweets #103

Open
Laurens256 opened this issue Sep 30, 2023 · 6 comments
Open

[FEATURE]: Downloading audio tweets #103

Laurens256 opened this issue Sep 30, 2023 · 6 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@Laurens256
Copy link
Contributor

Laurens256 commented Sep 30, 2023

Is your feature request related to a problem? Please describe.
The current behavior for audio tweets is kind of odd sometimes it does show a download button and sometimes it doesn't. It seems to be based on whether or not the user has interacted with the post but I couldn't figure out the exact behavior. See screenshots for audio post with & without download button
image
image
In this example I interacted with the second tweet (without a download button) by opening the tweet and playing some of the audio. Then after reloading the results page, all audio tweets had a download button except the one tweet i interacted with. The download button does work and it downloads the tweet as an mp4)

Describe the solution you'd like
A consistent option to download audio tweets, if possible as an audio file format but any video format is fine too

Describe alternatives you've considered
If you don't want to add this, maybe try to make the behavior more consistent but it's up to you obviously

Additional context
Not sure if it makes a difference but I'm on Firefox 118
Feel free to close if this is not something you plan on adding :) thanks for the extension regardless

@Laurens256 Laurens256 added the enhancement New feature or request label Sep 30, 2023
@Laurens256
Copy link
Contributor Author

I guess this could also be a bug since the downloading does work, the button just doesn't show up on all audio tweets

@EltonChou EltonChou added the bug Something isn't working label Sep 30, 2023
@EltonChou EltonChou self-assigned this Sep 30, 2023
@EltonChou EltonChou added this to the v4.3.0 milestone Sep 30, 2023
@EltonChou
Copy link
Owner

Thanks for report.

Could you share some audio tweet links with me ?
I don't have much audio-tweets in my timeline.

Most of the audio files were showed as a m3u8 file in the server, it could be converted into audio or video format easily,
but these tasks are not effficient to do in a web extension.
I might just export the m3u8 file and let users to do the convertion by theirselves.

@Laurens256
Copy link
Contributor Author

Sure:
https://twitter.com/Auroria_notes/status/1273901641729667074
https://twitter.com/SohileAli/status/1274396872459894784
https://twitter.com/pahayanmedia/status/1390737301236445186
https://twitter.com/GomezDeRulo/status/1316247023729868804
https://twitter.com/NiranjanUdas/status/1273846826911727616
https://twitter.com/SamW_NGC/status/1311011690398572546

I also recommend trying to search for "audiotweet"or something to see them in the feed form since the behavior is inconsistent in feed form vs this specific post form, i think this is weirdly handled by twitter but i'm not sure

@EltonChou
Copy link
Owner

I noticed the inconsistent problem, need some time for investigation. 👀

@EltonChou EltonChou modified the milestones: v4.3.0, 4.2.2 Oct 1, 2023
@EltonChou EltonChou modified the milestones: v4.2.2, v4.2.3 Oct 29, 2023
@Laurens256
Copy link
Contributor Author

To add onto this, I found that if you bookmark an audio tweet, it always becomes downloadable. This is because as far as I could see, twitter turns it into an mp4 rather than using the m3u8 extension. Very odd behavior by twitter

@EltonChou
Copy link
Owner

I think audio tweets were processed into mp4 and the autio space were m3u8.

@EltonChou EltonChou modified the milestones: v4.2.3, v4.3.0 Nov 26, 2023
@EltonChou EltonChou modified the milestones: v4.3.0, v5.0.0 Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants