Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Highlight downloaded images #126

Open
cyanlamp247 opened this issue Dec 11, 2023 · 5 comments
Open

[FEATURE] Highlight downloaded images #126

cyanlamp247 opened this issue Dec 11, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cyanlamp247
Copy link

Is your feature request related to a problem? Please describe.

Twitter has changed the layout of media. Now it is no longer possible to intuitively see which pictures have been downloaded.
屏幕截图 2023-12-11 171723

Describe the solution you'd like
1.Add a yellow border to the downloaded tweet image. The color of the border is the same as this button.
屏幕截图 2023-12-11 171912

The rendering is roughly like this. The red circle is the downloaded image with a yellow border.
屏幕截图 2023-12-11 171723--

2.Also add a download button on pages such as "/photo/1" and "/photo/2", such as this:
屏幕截图 2023-12-11 172837

In addition, a tweet can contain up to 4 pictures. This new download button can also be used to download one of the 4 pictures separately instead of downloading all 4 pictures.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@cyanlamp247 cyanlamp247 added the enhancement New feature or request label Dec 11, 2023
@EltonChou EltonChou self-assigned this Dec 11, 2023
@EltonChou EltonChou added this to the v4.3.0 milestone Dec 11, 2023
@EltonChou
Copy link
Owner

EltonChou commented Dec 11, 2023

Good ideas.
Do you think I need to add a download button on the thumbnail for current layout?

  1. This will change current behavior I will investigate it.

@cyanlamp247
Copy link
Author

Not bad, more practical than the method of adding borders I mentioned.

@EltonChou
Copy link
Owner

EltonChou commented Dec 11, 2023

But I think the border is a good idea too.
Sometimes, the thumbnail is too ellaborate and the button might confuses users.
I will try both in development.

@cheatreal321
Copy link

I would suggest adding a contrasting border or background to the download button on thumbnails to make it less confusing.
Personally I would love to have the option for a download button directly on the thumbnail, even if it looks a bit cluttered.
It would make downloading a bunch of tweets to add to a local folder/gallery much easier compared to having to click on each post to see the download button.

@cheatreal321
Copy link

Very simple mockup of what I'm imagining:
Before download
12 12 23_3464_firefox1
After download
12 12 23_3464_firefox2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

3 participants