Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] It doesn't work on x.com . #150

Closed
GeorgeMJ23 opened this issue May 17, 2024 · 31 comments · Fixed by #153
Closed

[BUG] It doesn't work on x.com . #150

GeorgeMJ23 opened this issue May 17, 2024 · 31 comments · Fixed by #153
Assignees
Labels
bug Something isn't working

Comments

@GeorgeMJ23
Copy link

Twitter must have made some changes to its code, so the Addon(in Firefox that I tried) it doesn't work. Even the download icon does not appear anymore.

@GeorgeMJ23 GeorgeMJ23 added the bug Something isn't working label May 17, 2024
@m1n1vv
Copy link

m1n1vv commented May 17, 2024

Yes. It's a similar problem in Edge. The update is only available for Chrome for now. But the download is not working.

@EltonChou
Copy link
Owner

EltonChou commented May 17, 2024

Twitter must have made some changes to its code, so the Addon(in Firefox that I tried) it doesn't work. Even the download icon does not appear anymore.

Firefox addon xpi file will be provided soon. (In release page).

Confirmed behavior:
Some api enpoints was forbidden for some users.
One of my account works good, the other was failed.

@EltonChou
Copy link
Owner

Yes. It's a similar problem in Edge. The update is only available for Chrome for now. But the download is not working.

Where is your ip location?

@m1n1vv
Copy link

m1n1vv commented May 17, 2024

Да. В Edge аналогичная проблема. Обновление пока доступно только для Chrome. Но загрузка не работает.

Где находится ваш IP-адрес?

Ukraine

@m1n1vv
Copy link

m1n1vv commented May 17, 2024

Yes. It's a similar problem in Edge. The update is only available for Chrome for now. But the download is not working.

Where is your ip location?

Is it possible to fix it?

@EltonChou
Copy link
Owner

Yes. It's a similar problem in Edge. The update is only available for Chrome for now. But the download is not working.

Where is your ip location?

Is it possible to fix it?

It will take sometime, but I think I can fix it.

@EltonChou EltonChou self-assigned this May 17, 2024
@m1n1vv
Copy link

m1n1vv commented May 17, 2024

Yes. It's a similar problem in Edge. The update is only available for Chrome for now. But the download is not working.

Where is your ip location?

Is it possible to fix it?

It will take sometime, but I think I can fix it.

I don't know how that's gonna help. Here is the message in the extension errors:

TwitterApiError: Your login session might be expired, please refresh your page.(statusCode: 403)

Context
sw.js
Stack trace
sw.js:2 (anonymous functions)

And I have another video download extension installed. It is working steadily now.

@adeteejay
Copy link

I just uninstalled and reinstalled and it's working again

@Nekodukin
Copy link

It doesn't work for me in Japan.
The FQDN for the PC version of the site has changed from twitter.com to x.com, and it appears that the extension no longer works.
It seems that the official X has announced the transition to x.com.

@Corleonis6422
Copy link

I also encountered the issue in Taiwan IP, reinstall the app doesn't resolve the problem.

@EltonChou EltonChou linked a pull request May 17, 2024 that will close this issue
@EltonChou
Copy link
Owner

The patch would be published tonight.

@EltonChou EltonChou reopened this May 17, 2024
@EltonChou EltonChou changed the title [BUG] Since today it doesn't work. [BUG] Since today it doesn't work on x.com . May 17, 2024
@EltonChou EltonChou changed the title [BUG] Since today it doesn't work on x.com . [BUG] It doesn't work on x.com . May 17, 2024
@EltonChou EltonChou pinned this issue May 17, 2024
@alaa-ayyad
Copy link

alaa-ayyad commented May 18, 2024

Version 4.2.6 works (Firefox), thanks!

One note: It started a brand new history repository, is it possible to continue using the existing history db?

@EltonChou
Copy link
Owner

Version 4.2.6 works Firefox, thanks!

One note: It started a brand new history repository, is it possible to continue using the existing history db?

Did you migrate from addons.mozilla.org version?

@alaa-ayyad
Copy link

alaa-ayyad commented May 18, 2024

Version 4.2.6 works Firefox, thanks!
One note: It started a brand new history repository, is it possible to continue using the existing history db?

Did you migrate from addons.mozilla.org version?

Thanks for the reply. I just used the xpi file in the release as recommended in readme.

I downloaded the source and built it but didn't know where to place the generated files under /dist.

@EltonChou
Copy link
Owner

Since the id of addon was not changed, it should use same repository.
What if you install an older version? Is the history changed?

@alaa-ayyad
Copy link

Yes, the sqlite files are created in different storage folder for each xpi version.
Please see the screenshot below, I tried to move the sqlite files from 4.2 to 4.2.6 folder, the older history list appears but without thumbnails, and the id in the About section is missed up (all x's),

explorer_pg5M6ccXpk

@EltonChou
Copy link
Owner

EltonChou commented May 18, 2024

v4.2 is last AMO store version with extension id [email protected]
v4.2.6 is self-signed version with extension id [email protected]

Firefox will treat them as different addons.
The history is stored in indexed DB, if you know how to manipulate it you can migrate it manually.

@alaa-ayyad
Copy link

I see, I noticed the difference in the id name in preference files. I will try to do the migration manually. Thank you.

@alaa-ayyad
Copy link

I was able to migrate the db:

  • Copied the .sqlite, .sqlite-shm, and .sqlite-wal files from C:\Users\<user>\AppData\Roaming\Mozilla\Firefox\Profiles\<your_profile>\storage\default\moz-extension+++<OLD_extension_id>\idb
    to
    C:\Users\<user>\AppData\Roaming\Mozilla\Firefox\Profiles\<your_profile>\storage\default\moz-extension+++<NEW_extension_id>\idb

  • Open the copied file using any SQLite viewer tool

  • Open table database

  • Under origin column edit the cell and change id part to the NEW_extension_id value:
    moz-extension://NEW_extension_id

Now you will be able to see the old history with working thumbnails and links.

@Gabarito007
Copy link

Gabarito007 commented May 18, 2024

Yes, version 4.2.6 is working well on Firefox.
Good job!

The history is stored in indexed DB, if you know how to manipulate it you can migrate it manually.

Off topic:

How to increase the number of items on the History page?
Currently, it shows only 20 entries per page.

@EltonChou
Copy link
Owner

How to increase the number of items on the History page?

Currently, it shows only 20 entries per page.

I will add more options.
But it will take some time, I'm not good at UI.

@Gabarito007
Copy link

I will add more options. But it will take some time, I'm not good at UI.

Great!
Many thanks.

@gpion
Copy link

gpion commented May 20, 2024

Still not working for me on Edge, no download ico,
Extension version 4.2.5 (chrome)

@lentilwallop
Copy link

when should we expect v4.2.6 to appear on the chrome web store?

@EltonChou
Copy link
Owner

when should we expect v4.2.6 to appear on the chrome web store?

Based on past experience, the review will take 1 - 5 days.

@Tamerlanchiques
Copy link

Strange. I can download media files of some posts, but some not.

(Firefox)

@EltonChou
Copy link
Owner

Strange. I can download media files of some posts, but some not.

(Firefox)

Please provdies those failed post.

@EltonChou
Copy link
Owner

when should we expect v4.2.6 to appear on the chrome web store?

From now on.

@Tamerlanchiques
Copy link

For example, I downloaded video from here and tried to do this again but I lose download button.

As of 20 of May:

image

As of now:

image

Firefox Mac 126.0 (64-bit)
Version 4.2.0 (firefox)

Yep, I noticed that I use old version but still strange that I downloaded something at 20 of May…

Long before I found your extention in Firefox addons site but could not find it now and can't download latest update. Why not host addon on Firefox Addons site?

@EltonChou
Copy link
Owner

For example, I downloaded video from here and tried to do this again but I lose download button.

As of 20 of May:

image

As of now:

image

Firefox Mac 126.0 (64-bit) Version 4.2.0 (firefox)

Yep, I noticed that I use old version but still strange that I downloaded something at 20 of May…

Long before I found your extention in Firefox addons site but could not find it now and can't download latest update. Why not host addon on Firefox Addons site?

Latest version .xpi file is in release page.

Firefox AMO ref: #112

@EltonChou
Copy link
Owner

v4.2.6 should fix this issue.

@EltonChou EltonChou unpinned this issue Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.