Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to download video from Card #85

Open
fireattack opened this issue Jul 14, 2023 · 2 comments
Open

[BUG] Unable to download video from Card #85

fireattack opened this issue Jul 14, 2023 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request pending

Comments

@fireattack
Copy link
Contributor

Describe the bug
Unable to download video inside a Card.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://twitter.com/DMMTV_ANIME_PR/status/1679687160398479362
  2. Click on download button

Expected behavior
Download the vid

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 114.0.5735.199
@fireattack fireattack added the bug Something isn't working label Jul 14, 2023
@EltonChou
Copy link
Owner

EltonChou commented Jul 14, 2023

Thanks for your report.

Card tweet parsing would be enhanced in the future version.
That would be helpful if you can provide more card type tweets which you think it should be downloadable.

@EltonChou EltonChou added this to the v4.2.0 milestone Jul 14, 2023
@EltonChou EltonChou added the enhancement New feature or request label Jul 14, 2023
@fireattack
Copy link
Contributor Author

fireattack commented Jul 15, 2023

I'd say any media_entities in result.card.legacy.binding_values.value.string_value, such as from https://twitter.com/Amamiyastaff/status/1673964451979202560

A slightly tricker case is swipeable media such as https://twitter.com/sacramusic_jp/status/1645713308995952640, where you need to make sure to order the image by slides, since their media entries are sometimes ordered differently (in this particular case, media_1 from slide 1 is using the second media in media_entities, for example).

I believe I've also seen result.card.(legacy.)binding_values.player_stream_url, but I can't find an example right now.

@EltonChou EltonChou self-assigned this Jul 30, 2023
@EltonChou EltonChou removed this from the v4.2.0 milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request pending
Projects
None yet
Development

No branches or pull requests

2 participants