Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Downloads fail outside of logged-in container (Firefox Containers) #99

Closed
offsetcyan opened this issue Sep 9, 2023 · 4 comments
Closed
Labels
bug Something isn't working firefox Firefox browser PR-welcome side effect by 3rd

Comments

@offsetcyan
Copy link

Describe the bug
If the extension is run from an account logged in via a Firefox container (official Mozilla extension) Media Harvest tries to download the media from outside of the container context. If the "no container" account isn't logged in, Media Harvest will fail as Twitter's API will reject the request.

To Reproduce
Steps to reproduce the behavior:

  1. Create a container and log in to twitter inside that container
  2. Make sure "no container" context is not logged in to Twitter
  3. Inside that container, try to activate the extension on some Twitter media

Expected behavior
Media is downloaded as expected.

Desktop (please complete the following information):

  • OS: NixOS 23.05
  • Browser: Firefox
  • Version: 117.0 (64-bit)
@offsetcyan offsetcyan added the bug Something isn't working label Sep 9, 2023
@EltonChou EltonChou self-assigned this Sep 11, 2023
@EltonChou
Copy link
Owner

EltonChou commented Sep 11, 2023

The addon backend was only loaded in the default container (no container).
If you logout twitter in default container, the addon cannot get useful twitter cookie from backend.
This can be fixed but the whole workflow need to be redesigned.
Since this issue was caused by other extension, I will not do the patch in the near future.

@EltonChou
Copy link
Owner

Firefox suuport was discarded.

@offsetcyan
Copy link
Author

LOL, why?

@EltonChou
Copy link
Owner

You can check #112 .
The firefox version would be only maintained for basic usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working firefox Firefox browser PR-welcome side effect by 3rd
Projects
None yet
Development

No branches or pull requests

2 participants