@ember/test-waiters getting required in production app? #184
Comments
|
I am pretty sure this is coming from 68b1954#diff-a3c0481f819ddcb17ceef5ebe509b39173047a05fd644b05c8f82d4180527961R5 |
|
@jacobq, Hi we haven't pushed the new version into our production app yet. We needed the update for a new project and was planning on updating our production app in the new year. So we haven't come across this yet. Since this module is integral to our production application, I will set aside time in the new year to help resolve issues that have come up and the things you mentioned in the last issue. In the meantime, hope you have a nice holiday season! :) |
jacobq
added a commit
that referenced
this issue
Dec 18, 2020
Note: For ember-qunit 5.x we had to add qunit and @ember/test-helpers as devDependencies See https://github.com/emberjs/ember-qunit/blob/master/docs/migration.md#upgrading-from-v4x-to-v500 fix(deps): move @ember/test-waiters to dependencies (ref #184) test: add DOM fixtures & move waiter to module scope The truth comes out: I (Jacob) did not actually read all of the ember-qunit 5.x migration guide that I mentioned in a previous commit. Oops :) This commit adds the DOM fixtures as explained here: https://github.com/emberjs/ember-qunit/blob/master/docs/migration.md#dom-fixtures It also addresses the warning triggered by accidentally recreating test waiters since `buildWaiter` was being called from within the class instead of at the module level as recommended by: https://github.com/emberjs/ember-test-waiters#use-buildwaiter-in-module-scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think the reason that this slipped through CI is that during testing we have the
devDependenciesinstalled so the module gets resolved. However, when I tried to use this (v0.6.0) in a production app I run into an error like this:@Gamma169 or @lsmun, did you encounter this problem?
The text was updated successfully, but these errors were encountered: