Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish fat APK in GitHub releases? #140

Closed
bartekpacia opened this issue Sep 9, 2024 · 3 comments · Fixed by #186 · May be fixed by #148
Closed

Publish fat APK in GitHub releases? #140

bartekpacia opened this issue Sep 9, 2024 · 3 comments · Fixed by #186 · May be fixed by #148

Comments

@bartekpacia
Copy link

Hey 👋 thanks for open-sourcing this project! Love it.

It'd be cool if we could download fat APKs directly from GitHub releases.

(Same goes for the iOS simulator builds when the iOS app becomes available)
@rbro112
Copy link
Contributor

rbro112 commented Sep 12, 2024

Thanks for the suggestion! We'll discuss as a team and let you know if we decide to do so.

Nonetheless, cloning the project currently and building should allow you to generate the full APK yourself for the time being (./gradlew :app:assembleRelease should do the trick).

@bartekpacia bartekpacia mentioned this issue Sep 12, 2024
Open
@bartekpacia
Copy link
Author

Hey, no need to discuss:D I did it in #148. I'll be grateful for a review.

@rbro112
Copy link
Contributor

rbro112 commented Sep 17, 2024

Thanks @bartekpacia! Will review shortly and let you know of any feedback.

chromy added a commit that referenced this issue Oct 16, 2024
@chromy
Build Android release whenever the app changes
81807e3 
Also:
- Produce a universal APK
- Upload that APK to the build artifacts
- If this is a release add that APK to the release also

This resolves #140. Thanks to bartekpacia@ for the initial commit.
@chromy chromy mentioned this issue Oct 16, 2024
Merged
chromy added a commit that referenced this issue Oct 16, 2024
@chromy
Build Android release whenever the app changes
31f75c1 
Also:
- Produce a universal APK
- Upload that APK to the build artifacts
- If this is a release add that APK to the release also

This resolves #140. Thanks to bartekpacia@ for the initial commit.
@chromy chromy closed this as completed in f97bb24 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rbro112 @bartekpacia