Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support componentsPath without slash #31

Merged
merged 2 commits into from
Dec 18, 2018
Merged

Support componentsPath without slash #31

merged 2 commits into from
Dec 18, 2018

Conversation

jnv
Copy link
Contributor

@jnv jnv commented Dec 17, 2018

Fixes #5

Additionally:

  • I have replaced forEach with for...of which requires less nesting and should have better performance
  • In tests, I have inlined path separators to resolve and swapped componentsDir with componentsDirWSlash to avoid repetition

@jnv jnv requested a review from jslovan December 17, 2018 14:44
@jnv jnv mentioned this pull request Dec 17, 2018
Closed
@jnv
Copy link
Contributor Author

jnv commented Dec 17, 2018 •
edited
Loading

BTW, I haven't opted for globby or similar packages since it would be a bigger rewrite with a risk of API breakage. It would be nice to be able to specify a glob pattern rather than having a fixed set of file extensions though, so I have opened #32 for that.

@jslovan jslovan merged commit c206e97 into master Dec 18, 2018
@jslovan jslovan deleted the jnv/ending-slash branch December 18, 2018 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jslovan jslovan jslovan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix treatment of directory path in componentPaths
2 participants
@jnv @jslovan