ComponentsPath may/may not end with a slash #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jnv
reviewed
Oct 31, 2018
| if (file !== '.' && file !== '..') { | ||
| this.findComponents( | ||
| `${componentsPath}${file}/`, | ||
| `${componentsPathSanit}${file}/`, |
There was a problem hiding this comment.
Why not just use path.join and avoid this string juggling?
Suggested change
| `${componentsPathSanit}${file}/`, | |
| path.join(componentsPath, file), |
jnv
reviewed
Oct 31, 2018
| const componentsPathSanit = componentsPath.endsWith('/') | ||
| ? componentsPath | ||
| : `${componentsPath}/`; | ||
| const files = fs.readdirSync(componentsPathSanit); |
There was a problem hiding this comment.
Another option would be to delegate this to module like glob or globby to recursively list files inside the directory.
jnv
changed the title
|
I''l branch-off this PR and replace the custom recursive loading logic with some existing module. |
|
Replaced by #31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5