Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GBP to supported currencies #3709

Open
tboltondev opened this issue Oct 24, 2024 · 5 comments
Open

Add GBP to supported currencies #3709

tboltondev opened this issue Oct 24, 2024 · 5 comments
Assignees
Labels
feature proposal Feature proposal for triage. Required for non-trivial features.

Comments

@tboltondev
Copy link

tboltondev commented Oct 24, 2024

In the application settings under 'Fiat Currency' there is no option to set the currency as British Pound (GBP).

I'm happy to work on this issue if it is agreed upon.

@stackchain
Copy link
Member

In the application settings under 'Fiat Currency' there is no option to set the currency as British Pound (GBP)

hey @tboltondev I think our BE right now doesn't support it, let me get the list. (we use 3 different providers and return the avg of them)

@stackchain
Copy link
Member

stackchain commented Oct 24, 2024

hey @tboltondev these are the supported (for now) currencies, I've created a ticket internally to add GBP

➜   curl https://api.yoroiwallet.com/api/price/ADA/current | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   423  100   423    0     0    502      0 --:--:-- --:--:-- --:--:--   502
{
  "error": null,
  "ticker": {
    "from": "ADA",
    "timestamp": 1729779602000,
    "signature": "c2cf0912a4dfdf7d458264e870dcfd0d799166b3b58df730c704c1907b7f92fc6a7e06b3204d13c1565455c37ea537cd53062328b0b0aeb0a4145e219bb8b60a",
    "prices": {
      "BRL": 1.970060027872007,
      "BTC": 5.0868777864984e-06,
      "CNY": 2.4522642374329973,
      "ETH": 0.00013643041714416211,
      "EUR": 0.318884279625629,
      "JPY": 52.427509597870475,
      "KRW": 475.33248051715555,
      "USD": 0.3445546334840945
    }
  }
}

@tboltondev
Copy link
Author

@stackchain cool, shall I leave this issue open then? Once it's added to the backend then this issue can be picked up I guess.

@stackchain
Copy link
Member

I created a task internally, next monday checking with Product, Ill keep it open for now.

@stackchain stackchain self-assigned this Oct 28, 2024
@stackchain stackchain added proposal Feature proposal for triage. Required for non-trivial features. feature labels Oct 28, 2024
@stackchain
Copy link
Member

Ticket - YV-96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature proposal Feature proposal for triage. Required for non-trivial features.
Projects
None yet
Development

No branches or pull requests

2 participants