Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix larastan on level 4 #413

Open
dmohns opened this issue Dec 11, 2024 · 0 comments
Open

Fix larastan on level 4 #413

dmohns opened this issue Dec 11, 2024 · 0 comments
Labels
Code base improvement Any improvements to the code base which makes it more maintainable or easier to use for users. enhancement New feature or request help wanted Extra attention is needed

Comments

@dmohns
Copy link
Member

dmohns commented Dec 11, 2024

Scope:

Currently larastan on level 4 reports errors which indicate broken code in our code base.

For each of the reported errors please decide, whether the corresponding code

  • should be removed as it's never used
  • should be fixed as the application will break if executed

Definition of done:

The larastan level in phpstan.neon is set to 4 and the Github Action step composer run larastan passes.

@dmohns dmohns added enhancement New feature or request help wanted Extra attention is needed Code base improvement Any improvements to the code base which makes it more maintainable or easier to use for users. labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code base improvement Any improvements to the code base which makes it more maintainable or easier to use for users. enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant