Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Compare branch package.json to main package.json #147

Open
annaruble-pfg opened this issue Feb 24, 2022 · 2 comments
Open

[Feature] Compare branch package.json to main package.json #147

annaruble-pfg opened this issue Feb 24, 2022 · 2 comments
Labels
good first issue Good for newcomers status: pinned Should not be labeled as stale type: feature New feature or feature request

Comments

@annaruble-pfg
Copy link

annaruble-pfg commented Feb 24, 2022

Is your feature request related to a problem? Please describe.
I need to be able to ensure PRs for my project have bumped the project package.json version when they commit new code.

Describe the solution you'd like
I want an action to fail a check if package.json hasn't been bumped by running this action from my branch against the main branch. Rather than specifying a file-url, it would be nice to be able to specify a branch instead, and then compare the two that way.

Describe alternatives you've considered
N/a

Additional context
Add any other context or screenshots about the feature request here.

@annaruble-pfg annaruble-pfg added the type: feature New feature or feature request label Feb 24, 2022
@EndBug EndBug added good first issue Good for newcomers status: pinned Should not be labeled as stale labels Feb 24, 2022
@EndBug
Copy link
Owner

EndBug commented Feb 24, 2022

Hi, thanks for opening the issue
It would be nice having a dedicated option, but for the time being, you can just enter the GitHub Raw URL in the file-url input and that should work
I'll keep this in mind though!

@delhiryder
Copy link

delhiryder commented Oct 13, 2022

Hi @EndBug - Great little github action ! I am also facing the same problem. I have tried to get this feature working by overloading the file-url input (with the latest version if the package.json file on the target branch of the pull request) and the assume-same-versions input set to old. However, my repository is private, so while the action (correctly) handles the ::before special string (by appending the github token to it), I get various failures (different ones for v1 and v2) if I put in the raw URL of my file.
Any thoughts on how this could be addressed ? (One way would be extend this syntax, to say something like ::branch-name=<insert-branch-name>. This modification would be the least disruptive, I think)
Regards,
Sidd (delhiryder)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers status: pinned Should not be labeled as stale type: feature New feature or feature request
Projects
None yet
Development

No branches or pull requests

3 participants