Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command line option -a doesn't match vspipe's behavior #18

Open
AkarinVS opened this issue Mar 22, 2021 · 3 comments
Open

command line option -a doesn't match vspipe's behavior #18

AkarinVS opened this issue Mar 22, 2021 · 3 comments

Comments

@AkarinVS
Copy link
Contributor

The current behavior of -a (passing command line to the script via sys.argv is incompatible with that of vspipe, which makes portable scripts impossible.

Another drawback is that sometimes you will have to double escape the arguments (i.e. when passing a value including a \). I think vspipe's -a is much nicer, and we don't need to bother with using shlex.split to reparse the command line.

I have a rough patch ready, but, before sending it in, I'd like to gather some opinions on this issue as it's an incompatible change.

@Endilll
Copy link
Owner

Endilll commented Mar 22, 2021

What is available now is a feature contributed by @wallace11, who considered vspipe's approach syntactically ugly. As for me, I don't have strong preference for any of them, and I don't see why VSP can't provide both. One more point I'd like to make is that vspipe-style arguments should use a key different to -a to prevent confusion of VSP users who have been using it.

@AkarinVS
Copy link
Contributor Author

AkarinVS commented Mar 23, 2021 via email

@Endilll
Copy link
Owner

Endilll commented Mar 23, 2021

-g and --global-vars, maybe?
Enabling autocompletion support for your use-case is sure a strong point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants