Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptation to changes introduced in EMB v0.7 #19

Merged
merged 8 commits into from
May 28, 2024
Merged

Conversation

JulStraus
Copy link
Member

EnergyModelsBase v0.7 changed how Storage nodes are handled through the introduction of a StorageBehaviour and AbstractStorageParameter.

As a consequence, we had to update EMRP to support the new structures.
This PR closes Issue 17.

@hellemo : Do you think the changes warrant an increase to 0.6 or is 0.5.7 sufficient? It includes most likely breaking changes for node development, but not for application through the introduction of the constructors. In practice, other packages should not depend on EMRP. Hence, I would argue that 0.5.7 should be ok.

Draft status until we decided version increase and I updated the NEWS.md

@JulStraus JulStraus added the enhancement New feature or request label May 27, 2024
@JulStraus JulStraus requested a review from hellemo May 27, 2024 13:57
@hellemo
Copy link
Member

hellemo commented May 27, 2024

I guess you could argue that because most of these changes are to support the breaking EMB release, this doesn't need to be breaking?

On the other hand, there are some new types, I didn't look to carefully if they are backwards compatible, but since this is for users upgrading to the new (breaking) EMB version, I think it is better and less confusing to release as v0.6.0, as users will need to update dependencies anyways.

@JulStraus
Copy link
Member Author

I guess you could argue that because most of these changes are to support the breaking EMB release, this doesn't need to be breaking?

On the other hand, there are some new types, I didn't look to carefully if they are backwards compatible, but since this is for users upgrading to the new (breaking) EMB version, I think it is better and less confusing to release as v0.6.0, as users will need to update dependencies anyways.

I agree. We do not add any new types in this PR, but we remove an older constructor. Given that, it makes sense in my opinion to go to 0.6.

@JulStraus JulStraus marked this pull request as ready for review May 28, 2024 06:22
@JulStraus JulStraus merged commit 86cbc7c into main May 28, 2024
6 checks passed
@JulStraus JulStraus deleted the enhanc/storage branch May 28, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjustments to changes in EMB
2 participants