Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to configure whether to overwrite results files #372

Open
alexdewar opened this issue Jan 31, 2025 · 0 comments
Open

Allow users to configure whether to overwrite results files #372

alexdewar opened this issue Jan 31, 2025 · 0 comments

Comments

@alexdewar
Copy link
Collaborator

Results files are currently written to muse2_results/{model_name}. If there are any files in there already, they will be overwritten.

We should allow users to choose whether or not to overwrite the files. I'd suggest that by default, we should raise an error if the output folder already exists, unless the user provides a command-line argument to overwrite it (e.g. --overwrite)1. I don't think we should make this configurable in settings.toml as it would make it too easy to accidentally overwrite data.

Another possibility is that we could append a timestamp to the folder name (i.e. muse2_results/{model_name}_{timestamp}) to reduce the chance of collisions. We could make this pattern configurable in settings.toml (see also #370) using some kind of formatted string (for which we'll probably need to add a crate which can do dynamic string formatting like this).

Footnotes

  1. Note: we should make sure to delete the contents of the folder before we start the run, so that we don't end up with a mix of files from the previous and current runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant