Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream loss in association establishment when association acceptor sends more PDUs in quick succession #589

Open
Enet4 opened this issue Nov 2, 2024 · 0 comments
Labels
A-lib Area: library bug This is a bug C-ul Crate: dicom-ul

Comments

@Enet4
Copy link
Owner

Enet4 commented Nov 2, 2024

Stream establishment depends on get_client_pdu, which parses the PDU data from an in-memory buffer. When establishing an association, a temporary buffer is created and immediately dropped.

This usually does not pose an issue because an association acceptance is usually followed by the SCP waiting for data from the SCU. However, if for some reason the SCP tries to send an A-ASSOCIATE-AC plus one or more PDUs in quick succession, this can make the association client fetch more bytes than the ones necessary for reading a single PDU.

This is a regression from #542, which was mitigated by #590 so that it would work on other scenarios.

@Enet4 Enet4 changed the title Soundness issue in association establishment when association acceptor sends more PDUs in quick succession Stream loss in association establishment when association acceptor sends more PDUs in quick succession Nov 2, 2024
@Enet4 Enet4 added bug This is a bug A-lib Area: library C-ul Crate: dicom-ul labels Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lib Area: library bug This is a bug C-ul Crate: dicom-ul
Projects
None yet
Development

No branches or pull requests

1 participant