Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options to skip check before lunching the server #375

Open
dalizi2333333 opened this issue Feb 6, 2025 · 4 comments
Open

Options to skip check before lunching the server #375

dalizi2333333 opened this issue Feb 6, 2025 · 4 comments

Comments

@dalizi2333333
Copy link

Describe your suggestion

make a option to directly lunch the server instead of checking whether the server can connect to those links before starting

Why would you like this added/changed?

Poor Chinese server hardly connect to those links, and I even can't use NeoForge's own run.bat to start the server to bypass those check, because it didn't work for some reason

@NielsPilgaard
Copy link
Collaborator

We actually have an option for that already, but I can see serverstarter doesn't actually honor it 😂
Your best bet is to make NeoForge's built in script work, or find the right commands in the server-setup-config.yaml file, updating the ServerStarter software is a fairly big task unfortunately.

@HeatherComputer
Copy link

Upon a tiny bit of digging - it does honour the property!
...but only after performing the check. That is to say, it performs the offline check and if the check fails, errors if the check is required.

Image

Source code shows this somewhat. If statements effectively evaluate left to right.

With that said - aside from the actual code changes, what barriers are there to updating the ServerStarter software? I imagine CF's moderation would play a role right?

@NielsPilgaard
Copy link
Collaborator

NielsPilgaard commented Feb 7, 2025

Surprisingly no 😂

It involves:

  • Submitting PR here: https://github.com/EnigmaticaModpacks/ServerStarter
  • Hope CI still works
  • Creating a release in that repo (I would do that)
  • Updating the server files of our modpacks (just E10 to start with) to download the new version of ServerStarter
GitHub
Contribute to EnigmaticaModpacks/ServerStarter development by creating an account on GitHub.

@HeatherComputer
Copy link

HeatherComputer commented Feb 8, 2025

Submitting PR here: https://github.com/EnigmaticaModpacks/ServerStarter

Done.

Hope CI still works

Rather than hoping, I've adjusted the 3-year old script to use the latest versions of the workflows it depends on. It works.

EnigmaticaModpacks/ServerStarter#7

GitHub
Contribute to EnigmaticaModpacks/ServerStarter development by creating an account on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants