Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spark profiler is set to autorun when single player (client) or server starts #908

Open
DoomSquirter opened this issue Mar 22, 2024 · 3 comments
Labels
Bug Modpack specific bug.

Comments

@DoomSquirter
Copy link

Modpack Version

1.9.1

Describe your issue.

in ./config/spark/ the config there is set to true that starts the profiler while server is booting. I don't have experience with client since I'm playing with server but the same setting is on the client as well

This means an extra load is put on server that's unnecessary and every time you do an actual profiler, after doing one it auto restarts it cause of that setting I think

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Server

Discord Username

DoomSquinter

@DoomSquirter DoomSquirter added the Bug Modpack specific bug. label Mar 22, 2024
@HeatherComputer
Copy link

It's worth noting that spark profiles have next to no impact on server performance - though I can confirm having some oddities when trying tj start a profiler of my own, and an autostarting profiler does not sound like something that should be enabled by default.

@MuteTiefling
Copy link
Contributor

So, I don't think this is actually set true in our configs. At least not that I'm seeing. @Darkere is it normal that backgroundProfiler defaults to true?

@Darkere
Copy link

Darkere commented Apr 6, 2024

yep seems like that is default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Modpack specific bug.
Projects
None yet
Development

No branches or pull requests

4 participants