Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog is clipped when appearing inside a dialog itself. #91

Open
ndawod opened this issue Nov 23, 2024 · 0 comments
Open

Dialog is clipped when appearing inside a dialog itself. #91

ndawod opened this issue Nov 23, 2024 · 0 comments

Comments

@ndawod
Copy link

ndawod commented Nov 23, 2024

I'm developing a web app that shows a dialog (a sort of form) with its own title and scrollable content area (overflow-y: auto; overflow-x: hidden). When the color picker dialog shows, it's clipped sadly...

Screenshot 2024-11-23 at 16 07 01

I believe this can be fixed in either of 2 ways:

  1. When the dialog appears, move it in the DOM tree to be in body (use bind:this and then on:focus to reposition it: body.appendChild(dialogEl).
  2. Accept a new parameter that helps the component to understand which element is its viewport. Then calculate positioning according to that container's position, rather than the DOM's body.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant