-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide and un-hide comment based on test results #300
Comments
…lt-action#300), also increase noise in check list by adding Gradle Build Scans
Nice! Shall we close this? The hiding part might be an extra scope to #41. |
This is a nice summary. I will leave this open for the hiding bit, which would be done separately. It is much easier and could be done first, so that good test results are posted as hidden comment, un-hidden on failure and re-hidden once fixed. Like it. |
Don't create the hidden comment on success, that's still noise and takes up vertical space, also email notification might be sent. |
Yes, but that bit IS #41. Can be freely combined with this feature here. |
Huh 👏 |
Hey, I'm thinking about an enhancement. Right now as far as I understand the only way to enable comments is if it always creates a comment, and then recycles that comment (default behavior).
Normally when everything is fine, creating comments is noisy in the PR, especially when there are different types of tests executed (e.g. unit, screenshot record, screenshot verify, UI tests, integration tests).
You can see how quickly the green test result comments get longer than the actual PR contents (conversation, commits, etc.).
So the following behavior would be nice:
The text was updated successfully, but these errors were encountered: