-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check is put into the wrong workflow group #488
Comments
Just looked into how the other GH Action is publishing the check run and I cannot see any parameter to pass the workflow as a context - but I'm not an expert. Maybe this still helps for reference: https://github.com/wearerequired/lint-action/blob/616f7ec78337552e970cf4879a3a5a042a7eb9e6/src/github/api.js |
This is a known limitation of the Checks API of Github. See #12 and the full story at https://github.com/orgs/community/discussions/24616. |
Thanks for the response and the hint to #12. Didn't know how things were called and hence could not search properly for existing issues :) Also read your comment at https://github.com/orgs/community/discussions/24616#discussioncomment-6088422. How GitHub handles this issue seems a bit weird to me, to say the least. Not too much hope that it gets resolved after 3+ years, while it seems such a simple request 🤷 Well, thanks for your time in providing this action and also responding to my request here! Cheers Closed as duplicate of #12. |
(Haha, just wanted to suggest pinning #12 to the top of the repo issues, just to see that you already did that before and I didn't see it. Lesson learned for me). |
Thanks for this helpful action!
The automatically created check gets put into the wrong "workflow group" in our PR checks (not sure how this "workflow group" is called actually).
So we have these outputs in our PR checks:
Automatic PR Unit Tests / app-unit-tests (pull_request) Successful in 6m
Automatic PR Unit Tests / publish-unit-test-results (pull_request) Successful in 17s
Lint / ESLint (pull_request) — No issues
Lint / Test Results (pull_request) — All 544 tests pass, 15 skipped in 4m 34s
The last check,
Test Results
, is created by this action and is put intoLint /
, while it should be put intoAutomatic PR Unit Tests /
. Is there a way to control that? Looks incorrect to me. Also we don't seem to re-use the nameTest Results
, so I don't think we have a duplication / conflict.This is the config we're using:
This is the log:
The text was updated successfully, but these errors were encountered: