Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: column headers #1031

Merged
merged 4 commits into from
Feb 13, 2025
Merged

fix: column headers #1031

merged 4 commits into from
Feb 13, 2025

Conversation

sagardspeed2
Copy link
Contributor

Describe your changes

fix: column headers to not shrink

Screenshots [Optional]

Issue ticket number and link

Closes #1025

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests
  • I have added a changeset pnpm changeset add
  • I have added example usage in the kitchen sink app

Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 7400ab3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ensembleui/react-runtime Patch
@ensembleui/react-kitchen-sink Patch
@ensembleui/react-preview Patch
@ensembleui/react-starter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Visit the preview URL for this PR (updated for commit 7400ab3):

https://react-kitchen-sink-dev--pr1031-1025-fix-column-head-vuzy6gg8.web.app

(expires Mon, 17 Feb 2025 14:33:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9

@sagardspeed2 sagardspeed2 self-assigned this Feb 8, 2025
Copy link
Member

@justEhmadSaeed justEhmadSaeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
image
image

): void => {
setSelectedValues(value);
if (action) onChangeCallback({ value, option });
if (action) onChangeCallback({ value, option: option ?? [] });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@@ -514,6 +515,7 @@ export const DataGrid: React.FC<GridProps> = (props) => {
}))}
hidden={col.visible === false}
key={colIndex}
minWidth={col.width ?? 100}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these both needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@sagardspeed2 sagardspeed2 requested a review from evshi February 10, 2025 17:56
@evshi evshi merged commit 0aaa92c into main Feb 13, 2025
3 checks passed
@evshi evshi deleted the 1025-fix-column-headers branch February 13, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty table columns have headers that break words
3 participants