-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: column headers #1031
fix: column headers #1031
Conversation
🦋 Changeset detectedLatest commit: 7400ab3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Visit the preview URL for this PR (updated for commit 7400ab3): https://react-kitchen-sink-dev--pr1031-1025-fix-column-head-vuzy6gg8.web.app (expires Mon, 17 Feb 2025 14:33:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
): void => { | ||
setSelectedValues(value); | ||
if (action) onChangeCallback({ value, option }); | ||
if (action) onChangeCallback({ value, option: option ?? [] }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
@@ -514,6 +515,7 @@ export const DataGrid: React.FC<GridProps> = (props) => { | |||
}))} | |||
hidden={col.visible === false} | |||
key={colIndex} | |||
minWidth={col.width ?? 100} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these both needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
Describe your changes
fix: column headers to not shrink
Screenshots [Optional]
Issue ticket number and link
Closes #1025
Checklist before requesting a review
pnpm changeset add