added saveFile action
#1799
Merged
added saveFile action
#1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mehsaandev no reviewer? is this draft? |
|
Yes this is draft, finishing it. |
snehmehta
requested changes
Jan 6, 2025
| } | ||
| } else if (source != null) { | ||
| // If blobData is not available, check for source (network URL) | ||
| Dio dio = Dio(); |
There was a problem hiding this comment.
why use dio when we have http package for network handling?
|
|
||
| /// Notify the Android media store about the new file | ||
| Future<void> _notifyFileSystem(String filePath) async { | ||
| try { |
There was a problem hiding this comment.
Running a process is not recommended if possible please find another way
|
|
||
| Future<void> _saveImageToDCIM(String fileName, Uint8List fileBytes) async { | ||
| try { | ||
| final result = await ImageGallerySaver.saveImage( |
There was a problem hiding this comment.
what is reason for using ImageGallerySaver, cause adding in android would be placing file on that location. is it ios?
There was a problem hiding this comment.
If I just place the file in that location it doesn't register the image in the gallery, using ImageGallerySaver it automatically registers the image to the gallery in the respective platforms I.e. Android and IOS
|
Due to the urgency of this fix, I would suggest having a meeting to go
through the PR. We need these done today as the customer is waiting
…On Mon, Jan 6, 2025 at 4:49 AM Muhammad Ehsaan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In modules/ensemble/lib/action/save_file.dart
<#1799 (comment)>:
> +
+ if (type == 'image') {
+ // Save images to Default Image Path
+ await _saveImageToDCIM(fileName!, fileBytes);
+ } else if (type == 'document') {
+ // Save documents to Documents folder
+ await _saveDocumentToDocumentsFolder(fileName!, fileBytes);
+ }
+ } catch (e) {
+ throw Exception('Failed to save file: $e');
+ }
+ }
+
+ Future<void> _saveImageToDCIM(String fileName, Uint8List fileBytes) async {
+ try {
+ final result = await ImageGallerySaver.saveImage(
If I just place the file in that location it doesn't register the image in
the gallery, using ImageGallerySaver it automatically registers the image
to the gallery in the respective platforms I.e. Android and IOS
—
Reply to this email directly, view it on GitHub
<#1799 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACMZUAVTSRUKVKFFYWXNST32JJ3W3AVCNFSM6AAAAABUN44GL6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMZSGA3TMMRRG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I've made the required changes.
@snehmehta PTAL |
snehmehta
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.