if FORK_URL is defined, use that as url
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t from chain_id_to_fork
8times4
changed the title
fork_url is defined, use that url FORK_URL is defined, use that as url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Team,
I've had some issues running this by default for Base, since no matter if the
FORK_URLwas defined, it'd simply getCHAIN_ID_NOT_SUPPORTEDerror aschain_id_to_fork_urlfunction does not have Base statically added.I'm proposing this fix, since when passing
FORK_URLin, you're already constrained to use that chain for simulation, else you getINCORRECT_CHAIN_ID, so it just allows the usage of more than the static chains.Best,
8x4