const prop for log and logp1 #218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Jan 4, 2025
| auto resultType = op.getType().cast<ShapedType>(); | ||
|
|
||
| // Convert constant to tensor, compute log, then convert back to attribute | ||
| stablehlo::Tensor inputTen = mlir::stablehlo::constantOp(inputAttr); |
There was a problem hiding this comment.
Look at some of the other examples, can you add a fast path if the attribute is a splat (so we don’t need to compute the same value for a huge constant of the same inputs)
There was a problem hiding this comment.
Kind of like here?
There was a problem hiding this comment.
more like this:
There was a problem hiding this comment.
otherwise we end up iterating through all inputs: https://github.com/openxla/stablehlo/blob/c06b1a10d66069505ccbab72b21f6fa0547c617d/stablehlo/reference/Ops.cpp#L1911
There was a problem hiding this comment.
Ah I see so replacement will still be the same, we are just playing around with the tensor type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #212