Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails5 #187

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Rails5 #187

wants to merge 11 commits into from

Conversation

Chocksy
Copy link
Member

@Chocksy Chocksy commented Jul 6, 2016

Fixes #173 .

Changes proposed in this pull request:

  • updated ruby from 2.2.2 to 2.3.0
  • update all gems required and dependencies
  • stop using render nothing: true and use head :ok
  • for activerecord calls use distinct instead of unq
  • update all rspec controller calls to use a hash syntax
  • use throw :abort in model callbacks as return false does not stop the chain
  • need to fix the rake db:schema:load command
  • fix all the rspec tests
  • do some testing of the app and make sure it still works
  • create a heroku review app and try to hit the app with errors and see if they register

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to rails 5
1 participant